Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: tenantrate: deflake testcloser #88321

Merged
merged 1 commit into from
Sep 22, 2022
Merged

release-22.2: tenantrate: deflake testcloser #88321

merged 1 commit into from
Sep 22, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 21, 2022 •
edited by kvoli
Loading

Backport 1/1 commits from #88303 on behalf of @kvoli.

/cc @cockroachdb/release

This patch increases the request size in TestCloser in order to jam the request, to assert on timers closing. An earlier patch lowered the RU cost below the burst threshold, making it so that this request never waited.

The test previously flaked after 1 run.

53538 runs so far, 0 failures, over 2m5s

resolves: #86822

Release note: None

Release justification: fix flaky test and un-skip.

@kvoli
tenantrate: deflake testcloser
23179a5 
This patch increases the request size in `TestCloser` in order to jam
the request, to assert on timers closing. An earlier patch lowered the
RU cost below the burst threshold, making it so that this request never
waited.

The test previously flaked after 1 run.

`53538 runs so far, 0 failures, over 2m5s`

resolves: #86822

Release note: None
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 21, 2022
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 21, 2022 01:00
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-88303 branch 2 times, most recently from ac55929 to fff6ddb Compare September 21, 2022 01:00
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 21, 2022 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli
Copy link
Collaborator

kvoli commented Sep 22, 2022

bors r=irfansharf

@irfansharif
Copy link
Contributor

bors r-

(No bors on backports; mucks with the merge queue)

@craig
Copy link
Contributor

craig bot commented Sep 22, 2022

Canceled.

@kvoli kvoli merged commit 1009941 into release-22.2 Sep 22, 2022
@kvoli kvoli deleted the blathers/backport-release-22.2-88303 branch September 22, 2022 14:46
@kvoli
Copy link
Collaborator

kvoli commented Sep 22, 2022

mb 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees

@kvoli kvoli

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @kvoli @irfansharif