release-22.2: kvcoord: (partially) de-flake tpcc/multiregion #88211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Touches #85711 fixing one of the failure modes. In #85101 we deleted code in the span refresher interceptor that terminated WriteTooOld flags. We did so assuming these flags were only set in 19.2 servers, but that's not the case -- TestWTOBitTerminatedOnErrorResponses demonstrates that it's possible for the server to return error responses with the bit set if a response is combined with an error from another request in the same batch request. Since we were no longer terminating the flag, it was possible to update the TxnCoordSender's embedded txn with this bit, an then use it when issuing subsequent batch requests -- something we were asserting against. Release note: None Release justification: Bug fix
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-87739
branch
from
debf7aa to
ecadcb2
Compare
blathers-crl
bot
requested review from
irfansharif,
nvanbenschoten and
yuzefovich
blathers-crl
bot
added
blathers-backport
|
This change is |
nvanbenschoten
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #87739 on behalf of @irfansharif.
/cc @cockroachdb/release
Touches #85711 fixing one of the failure modes. In #85101 we deleted
code in the span refresher interceptor that terminated WriteTooOld
flags. We did so assuming these flags were only set in 19.2 servers, but
that's not the case -- TestWTOBitTerminatedOnErrorResponses demonstrates
that it's possible for the server to return error responses with the bit
set if a response is combined with an error from another request in the
same batch request.
Since we were no longer terminating the flag, it was possible to update
the TxnCoordSender's embedded txn with this bit, an then use it when
issuing subsequent batch requests -- something we were asserting
against.
Release note: None
Release justification: Bug fix
Release justification: