admission: enable elastic cpu control by default #88031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
We want to have this bake through the 23.1 development cycle. Release note: None (not being backported)
irfansharif
force-pushed
the
220915.enable-elastic-cpu
branch
from
6ea7dc7 to
e64852f
Compare
sumeerbhola
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andrewbaptist)
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Sep 20, 2022
Fixes cockroachdb#88269, fallout from cockroachdb#88031 -- sloppy assumption that the token bucket type is thread-safe. Instantly reproduced using: dev test pkg/ccl/changefeedccl \ -f=TestAlterChangefeedAddTarget/cloudstorage \ --race --stress --timeout 1m Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Sep 20, 2022
Fixes cockroachdb#88269, fallout from cockroachdb#88031 -- sloppy assumption that the token bucket type is thread-safe. Instantly reproduced using: dev test pkg/ccl/changefeedccl \ -f=TestAlterChangefeedAddTarget/cloudstorage \ --race --stress --timeout 1m Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
88241: cdc: fix assignment to nil map panic in json encoder r=[miretskiy] a=HonoreDB JSON encoding a delete message for a deleted row was panicking. This fixes that. Release note (bug fix): Fixed a crash in changefeed expressions when JSON encoding an empty projection. 88272: cli/sql: delay writing the history file to the end r=DrewKimball a=knz Fixes #54679. Previously, the shell would write to the history file in-between each input. This was incurring noticeable delays if the history file was large. This patch fixes that by delaying the file write until the end. This is akin to the behavior of unix shell. There is no user-visible change except in the case of a crash of the shell itself, which at this point has become extremely rare. Release note: None 88275: upgrade/upgrades: make schema telemetry migration idempotent r=ajwerner a=ajwerner Fixes #88273 Release note: None 88279: admission: squash data race in accessing token bucket r=irfansharif a=irfansharif Fixes #88269, fallout from #88031 -- sloppy assumption that the token bucket type is thread-safe. Instantly reproduced using: dev test pkg/ccl/changefeedccl \ -f=TestAlterChangefeedAddTarget/cloudstorage \ --race --stress --timeout 1m Release note: None Release justification: Fixes data race in non-production code 88300: stats: make recent fix more conservative r=yuzefovich a=yuzefovich We recently merged a fix for histograms of INT2 and INT4 types to not exceed their range, and we used an exact equality against the boundary values when determining whether "outer" buckets are needed. This commit makes that logic more bullet-proof by using an inequality. The sampled values that exceed the supported ranges for the types should not really happen, but let's be conservative. Release note: None Co-authored-by: Aaron Zinger <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Andrew Werner <[email protected]> Co-authored-by: irfan sharif <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have this bake through the 23.1 development cycle.
Release note: None (not being backported)