server/settingswatcher: track timestamps so values do not regress #87564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Ignore the failed tests, this is RFAL |
dt
approved these changes
Sep 8, 2022
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
| if existing, ok := s.mu.values[name]; ok && sv.ts.Less(existing.ts) { | ||
| return |
There was a problem hiding this comment.
nit: a comment here (or on the func) as to why it'd be out of order might be nice; I'd ague I'd have expected it here more than on the struct.
HonoreDB
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @dt, and @HonoreDB)
ajwerner
force-pushed
the
ajwerner/make-settings-watcher-handle-stale-updates
branch
from
9583140 to
8769b3b
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
A rangefeed is allowed to send previously seen values. When it did, it would result in the observed value of a setting regressing. There's no need for this: we can track some timestamps and ensure we do not regress. Fixes cockroachdb#87502 Relates to cockroachdb#87201 Release note (bug fix): In rare cases, the value of a cluster setting could regress soon after it was set. This no longer happens for a given gateway node.
ajwerner
force-pushed
the
ajwerner/make-settings-watcher-handle-stale-updates
branch
from
8769b3b to
ffea578
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
This turns out to matter for testing. blathers backport 22.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rangefeed is allowed to send previously seen values. When it did, it would result in the observed value of a setting regressing. There's no need for this: we can track some timestamps and ensure we do not regress.
Fixes #87502
Relates to #87201
Release note (bug fix): In rare cases, the value of a cluster setting could regress soon after it was set. This no longer happens for a given gateway node.