Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add optional white background to PageConfig #87313

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

absterr08
Copy link
Contributor

Previously, the PageConfig component had a fixed grey
background to match the page background, since it is a sticky
component that needs a background color to cover content that
scrolls beneath it. However, the background color is changing
to white in CockroachCloud, so the background color needs to
be able to match the new background. Until we apply the layout
changes to db-console, this change allows us to specify a
different background color in CockroachCloud.

This change uses CockroachCloudContext to determine whether or
not the PageConfig background color should be white.

Without white background
Screen Shot 2022-08-31 at 12 11 39 PM

With white background
Screen Shot 2022-08-31 at 12 11 56 PM

Release note: None

Release justification: ui change for cluster-ui components used
in cockroach cloud

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)

@absterr08 absterr08 force-pushed the page-config-white-background branch from 1b40577 to eb308cd Compare September 6, 2022 20:42
Previously, the PageConfig component had a fixed grey
background to match the page background, since it is a sticky
component that needs a background color to cover content that
scrolls beneath it. However, the background color is changing
to white in CockroachCloud, so the background color needs to
be able to match the new background. Until we apply the layout
changes to `db-console`, this change allows us to specify a
different background color in CockroachCloud.

This change uses CockroachCloudContext to determine whether or
not the PageConfig background color should be white.

Release note: None

Release justification: ui change for cluster-ui components used
in cockroach cloud
@absterr08 absterr08 force-pushed the page-config-white-background branch from eb308cd to d9632c0 Compare September 6, 2022 21:05
@absterr08
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit 7a3edae into cockroachdb:master Sep 7, 2022
@absterr08
Copy link
Contributor Author

TFTR!

@absterr08
Copy link
Contributor Author

blathers backport 22.2

@blathers-crl
Copy link

blathers-crl bot commented Sep 9, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d9632c0 to blathers/backport-release-22.2-87313: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants