-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add optional white background to PageConfig #87313
ui: add optional white background to PageConfig #87313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
1b40577
to
eb308cd
Compare
Previously, the PageConfig component had a fixed grey background to match the page background, since it is a sticky component that needs a background color to cover content that scrolls beneath it. However, the background color is changing to white in CockroachCloud, so the background color needs to be able to match the new background. Until we apply the layout changes to `db-console`, this change allows us to specify a different background color in CockroachCloud. This change uses CockroachCloudContext to determine whether or not the PageConfig background color should be white. Release note: None Release justification: ui change for cluster-ui components used in cockroach cloud
eb308cd
to
d9632c0
Compare
bors r+ |
Build failed (retrying...): |
Build succeeded: |
TFTR! |
blathers backport 22.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d9632c0 to blathers/backport-release-22.2-87313: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, the PageConfig component had a fixed grey
background to match the page background, since it is a sticky
component that needs a background color to cover content that
scrolls beneath it. However, the background color is changing
to white in CockroachCloud, so the background color needs to
be able to match the new background. Until we apply the layout
changes to
db-console
, this change allows us to specify adifferent background color in CockroachCloud.
This change uses CockroachCloudContext to determine whether or
not the PageConfig background color should be white.
Without white background
With white background
Release note: None
Release justification: ui change for cluster-ui components used
in cockroach cloud