bazci: fix output path computation #87117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These updates were happening in-place so `bazci` was constructing big, silly paths like `backupccl_test/shard_6_of_16/shard_7_of_16/shard_13_of_16/...` We just need to copy the variable here. Release justification: Non-production code changes Release note: None
|
This change is |
rail
approved these changes
Aug 30, 2022
jlinder
reviewed
Aug 30, 2022
| @@ -185,6 +185,7 @@ func processBuildEventProtocolLog(action, bepLoc string) error { | |||
| outputDir = filepath.Join("bazel-testlogs", outputDir) | |||
| summary := event.GetTestSummary() | |||
| for _, testResult := range testResults[label] { | |||
| outputDir := outputDir | |||
There was a problem hiding this comment.
This looks like outputDir is just overwriting itself. What am I missing about how it works?
There was a problem hiding this comment.
outputDir := outputDir declares a new variable with the same name as the old one. It shadows the original variable in a new scope. That means we can update the value in the loop but each iteration will get the original value of outputDir.
|
Results in CI look good. bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates were happening in-place so
bazciwas constructing big,silly paths like
backupccl_test/shard_6_of_16/shard_7_of_16/shard_13_of_16/...We just need to copy the variable here.
Release justification: Non-production code changes
Release note: None