Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgcode: use custom error codes for home region errors #86965

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Aug 26, 2022

The XC error class is reserved for Cockroach-specific errors to avoid
conflicting with any future error codes that Postgres might add.

Release note: None

Release justification: low risk change to new functionality.

@rafiss rafiss requested review from msirek and a team August 26, 2022 20:36
@rafiss rafiss requested a review from a team as a code owner August 26, 2022 20:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

The XC error class is reserved for Cockroach-specific errors to avoid
conflicting with any future error codes that Postgres might add.

Release note: None

Release justification: low risk change to new functionality.
@rafiss rafiss force-pushed the fix-home-region-codes branch from 34b40eb to 60b59e4 Compare August 26, 2022 21:01
@rafiss
Copy link
Collaborator Author

rafiss commented Aug 26, 2022

tftr!

bors r=msirek

@craig
Copy link
Contributor

craig bot commented Aug 26, 2022

Build succeeded:

@craig craig bot merged commit 50256c3 into cockroachdb:master Aug 26, 2022
@rafiss rafiss deleted the fix-home-region-codes branch August 30, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants