ui: properly construct timescale object from session storage #86909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
Previously, when we restore the global timescale object from session storage, we did not properly construct non primitive type fields. This commit properly constructs the TimeScale object from session storage, reconstructing the moment.duration and moment objects that are expected in certain fields. Release justification: bug fix Release note (bug fix): timescale object is properly constructed from session storage, preventing bugs and crashes in pages that use the time scale object when reloading the page
xinhaoz
force-pushed
the
fix-ts-from-session-store
branch
from
6dbc954 to
b01b104
Compare
|
Failures look unrelated. |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when we restore the global timescale object from session
storage, we did not properly construct non primitive type fields. This
commit properly constructs the TimeScale object from session storage,
reconstructing the moment.duration and moment objects that are expected
in certain fields.
Release justification: bug fix
Release note (bug fix): timescale object is properly constructed
from session storage, preventing bugs and crashes in pages that use
the time scale object when reloading the page