backupccl, restoreccl: include system.privileges in full cluster restore #86830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
reviewed
Aug 25, 2022
There was a problem hiding this comment.
There are a few other tests to update:
- TestClusterRestoreFailCleanup has a some lists of tables that should transition to a DROP state on revert. We need to add this new table to that list:
https://github.com/cockroachdb/cockroach/blob/master/pkg/ccl/backupccl/full_cluster_backup_restore_test.go#L732
If you are feeling generous, you could also add it to:
| @@ -538,7 +538,7 @@ var systemTableBackupConfiguration = map[string]systemBackupConfiguration{ | |||
| expectMissingInSystemTenant: true, | |||
| }, | |||
| systemschema.SystemPrivilegeTable.GetName(): { | |||
| shouldIncludeInClusterBackup: optOutOfClusterBackup, | |||
| shouldIncludeInClusterBackup: optInToClusterBackup, // No desc ID columns. | |||
There was a problem hiding this comment.
✅ Double checked that it looks like the format for the path element in the table also doesn't use any IDs that need rewritting.
Release justification: Minor enhancement to not yet released feature Release note: None
RichardJCai
force-pushed
the
include_system_privileges_in_restore
branch
from
1b8d983 to
2d485fb
Compare
|
CI failure is flake bors r=stevendanna |
|
👎 Rejected by too few approved reviews |
|
Nvm need github approval @stevendanna |
stevendanna
approved these changes
Aug 26, 2022
|
bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: Minor enhancement to not yet released feature
Release note: None
Fixes #84762