Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: rename MVCCRangeKeyStack.FirstAbove/Below #86748

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

erikgrinaker
Copy link
Contributor

This patch renames FirstAbove/Below to FirstAtOrAbove/Below, for
clarity.

Release justification: bug fixes and low-risk updates to new functionality

Release note: None

@erikgrinaker erikgrinaker requested a review from tbg August 24, 2022 12:53
@erikgrinaker erikgrinaker self-assigned this Aug 24, 2022
@erikgrinaker erikgrinaker requested review from a team as code owners August 24, 2022 12:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
Copy link
Contributor Author

bors r=tbg

@erikgrinaker
Copy link
Contributor Author

This is going to skew with #86742, holding off.

bors r-

@craig
Copy link
Contributor

craig bot commented Aug 24, 2022

Canceled.

This patch renames `FirstAbove/Below` to `FirstAtOrAbove/Below`, for
clarity.

Release justification: bug fixes and low-risk updates to new functionality

Release note: None
@erikgrinaker
Copy link
Contributor Author

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@craig craig bot merged commit 54bc65f into cockroachdb:master Aug 25, 2022
@erikgrinaker erikgrinaker deleted the rangekey-atorabove branch August 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants