Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: add COPY to sampled_query logging #86717

Closed

Conversation

otan
Copy link
Contributor

@otan otan commented Aug 24, 2022

Backport 1/1 commits from #86627.

/cc @cockroachdb/release


As requested by product, we want COPY to show up on sampled_query. This
commit adds this, whilst fudging a few things presumably more relevant
to "regular" DDL statements.

Release justification: telemetry only change

Release note: None

@otan otan requested a review from cucaroach August 24, 2022 00:02
@blathers-crl
Copy link

blathers-crl bot commented Aug 24, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan force-pushed the backport21.2-86627 branch from 80e1683 to 05f3a4c Compare August 24, 2022 00:03
@otan
Copy link
Contributor Author

otan commented Aug 24, 2022

blathers backport 22.1

@otan otan force-pushed the backport21.2-86627 branch 2 times, most recently from 3d36515 to 1e02a3e Compare August 25, 2022 14:33
@otan otan force-pushed the backport21.2-86627 branch 3 times, most recently from fffe07b to 559d492 Compare August 26, 2022 01:04
As requested by product, we want COPY to show up on sampled_query. This
commit adds this, whilst fudging a few things presumably more relevant
to "regular" DDL statements.

Release justification: telemetry only change

Release note: None
@otan otan force-pushed the backport21.2-86627 branch from 559d492 to dac54ce Compare August 26, 2022 05:32
@otan
Copy link
Contributor Author

otan commented Aug 28, 2022

going to redo this - a lot has changed.

@otan otan closed this Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants