colexec: fix a couple of issues with the new range stats operator #86715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a couple of issues with the new range stats operator: - it adds the null check for each value before using it as a key - it performs a copy of each non-null value before appending it to the slice of the `roachpb.Key`s. This is the limitation of the KV API where keys cannot be mutated on the client side once the BatchRequest is issued, and we will mutate the incoming `Bytes` vector since it is reset and reused. In theory, this copy should not be necessary, but the race gRPC transport complains if the copy is not made. Release justification: fixes of new functionality. Release note: None
|
This change is |
ajwerner
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a couple of issues with the new range stats operator:
slice of the
roachpb.Keys. This is the limitation of the KV API wherekeys cannot be mutated on the client side once the BatchRequest is
issued, and we will mutate the incoming
Bytesvector since it is resetand reused. In theory, this copy should not be necessary, but the race
gRPC transport complains if the copy is not made.
Fixes: #86545.
Release justification: fixes of new functionality.
Release note: None