builtins: fix json_build_object for enums and void in the key #86675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would run into an internal error with `json_build_object` builtin if an enum or void was passed for the key part, and this is now fixed. This commit also sorts all datums lexicographically to make it easier to see whether all scalar datums are mentioned. Release justification: bug fix. Release note (bug fix): Previously, CockroachDB would return an internal error when evaluating `json_build_object` builtin when an enum or a void datums were passed as the first argument, and this is now fixed.
|
This change is |
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would run into an internal error with
json_build_objectbuiltin if an enum or void was passed for the key part, and this is now
fixed. This commit also sorts all datums lexicographically to make it
easier to see whether all scalar datums are mentioned.
Fixes: #84368.
Release justification: bug fix.
Release note (bug fix): Previously, CockroachDB would return an internal
error when evaluating
json_build_objectbuiltin when an enum or a voiddatums were passed as the first argument, and this is now fixed.