changefeedccl: Add options to enable the use of MuxRangeFeed RPC #86448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
force-pushed
the
usemux
branch
4 times, most recently
from
82c2604 to
bf97c61
Compare
|
@jayshrivastava I decided to remove 1 commit (adding similar option to rangefeed library). This one is now purely for changefeeds. |
miretskiy
changed the title
jayshrivastava
approved these changes
Aug 22, 2022
| @@ -74,8 +75,13 @@ func (p rangefeedFactory) Run(ctx context.Context, sink kvevent.Writer, cfg rang | |||
| } | |||
| g := ctxgroup.WithContext(ctx) | |||
| g.GoCtx(feed.addEventsToBuffer) | |||
| var rfOpts []kvcoord.RangeFeedOption | |||
| if cfg.UseMux { | |||
There was a problem hiding this comment.
I don't think that this is ever set to true. Please add UseMux: f.useMux, to the struct initialization in kvevent.runUntilTableEvent.
There was a problem hiding this comment.
I assume what I said above is the intended behavior. As in, the changefeed should pass the setting down to the underlying rangefeed.
Enable changefeed to use `MuxRangeFeed` RPC if `changefeed.mux_rangefeed.enabled` is set to true. Release note (enterprise change): Changefeeds may opt in via `changefeed.mux_rangefeed.enabled` setting to use `MuxRangeFeed` RPC which multiplexes multipe range feed streams onto a single RPC stream per node. Release justification: add option to enable functionality that's disabled by default.
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable changefeed to use
MuxRangeFeedRPC ifchangefeed.mux_rangefeed.enabledis set to true.Release note (enterprise change): Changefeeds may opt in
via
changefeed.mux_rangefeed.enabledsetting to useMuxRangeFeedRPC which multiplexes multipe range feed streamsonto a single RPC stream per node.
Release justification: add option to enable functionality
that's disabled by default.