Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterversion,storage: remove EnablePebbleFormatVersionBlockProperties #86437

Conversation

celiala
Copy link
Collaborator

@celiala celiala commented Aug 19, 2022

Release justification: remove old version gate
Release note: None

Partially addresses #80663

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@celiala celiala marked this pull request as ready for review August 19, 2022 13:40
@celiala celiala requested a review from a team as a code owner August 19, 2022 13:40
@celiala
Copy link
Collaborator Author

celiala commented Aug 19, 2022

I'm not sure how to fix these failing tests -- hopefully someone on Storage can help here?

These tests are failing:

  • pkg/upgrade/upgrademanager: TestPrecondition
  • pkg/ccl/jobsccl/jobsprotectedtsccl: TestJobsProtectedTimestamp/system-tenant

TestJobsProtectedTimestamp/system-tenant gives:

/go/src/github.com/cockroachdb/cockroach/pkg/ccl/jobsccl/jobsprotectedtsccl/jobs_protected_ts_test.go:176
          Error:        Received unexpected error:
                        protected timestamp record does not exist

Release note: None
Release justification: remove old version gate

Release note (<category, see below>): <what> <show> <why>
@celiala celiala force-pushed the remove-gate.EnablePebbleFormatVersionBlockProperties branch from dace1b5 to 9f91371 Compare August 19, 2022 13:57
@nicktrav
Copy link
Collaborator

@bananabrick - mind taking a look at this?

@nicktrav nicktrav requested a review from bananabrick August 19, 2022 14:07
@bananabrick
Copy link
Contributor

Removed in this #86337

@celiala
Copy link
Collaborator Author

celiala commented Aug 22, 2022

Closing in favor of #86337

@celiala celiala closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants