Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: move comments to SimpleIterator #86389

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Aug 18, 2022

Previously, methods on SimpleIterator referenced other methods not
on that interface. This was confusing. Now the wider interface
references the narrower one.

Release justification: comments fix
Release note: None

@tbg tbg requested a review from a team as a code owner August 18, 2022 15:22
@tbg tbg requested a review from a team August 18, 2022 15:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

pkg/storage/engine.go Outdated Show resolved Hide resolved
Previously, methods on SimpleIterator referenced other methods not
on that interface. This was confusing. Now the wider interface
references the narrower one.

Release justification: comments fix
Release note: None
@tbg tbg force-pushed the storage-mvcc-comment branch from 01a98fc to 3ccbf67 Compare August 22, 2022 08:45
@tbg
Copy link
Member Author

tbg commented Aug 22, 2022

bors r=erikgrinaker
🙇🏽

@craig
Copy link
Contributor

craig bot commented Aug 22, 2022

Build succeeded:

@craig craig bot merged commit a50a783 into cockroachdb:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants