roachtest: deflake kv0/enc=false/../no-admission #86388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Aug 18, 2022
|
bors r+ |
Fixes cockroachdb#86299 (speculatively). It doesn't seem this perf test cared about failing the entire test run in the face of errors (the errors tripping the roachtest were as a result of circuit breakers tripping, possible without admission control which this test disabled). While here, we also switch off admission.kv.pause_replication_io_threshold for configurations where admission is disabled -- it gives us a fuller comparison point. Release justification: stability work Release note: None
irfansharif
force-pushed
the
220818.deflake-kv0/enc=false
branch
from
c6db5be to
2cfc958
Compare
|
bors r+ |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86299 (speculatively). It doesn't seem this perf test cared about
failing the entire test run in the face of errors (the errors tripping
the roachtest were as a result of circuit breakers tripping, possible
without admission control which this test disabled). While here, we also
switch off admission.kv.pause_replication_io_threshold for
configurations where admission is disabled -- it gives us a fuller
comparison point.
Release justification: stability work
Release note: None