Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add feature flag checking for UDF statements #86342

Merged
merged 1 commit into from
Aug 18, 2022
Merged

sql: add feature flag checking for UDF statements #86342

merged 1 commit into from
Aug 18, 2022

Conversation

chengxiong-ruan
Copy link
Contributor

Release note: None
Release justification: low risk feature flags for DDL statements.

@chengxiong-ruan
sql: add feature flag checking for UDF statements
4e01fb1 
Release note: None
Release justification: low risk feature flags for DDL statements.
@chengxiong-ruan chengxiong-ruan requested a review from a team August 17, 2022 22:00
@cockroach-teamcity
Copy link
Member

This change is Reviewable

ajwerner
ajwerner approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xiang-Gu
Xiang-Gu approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@Xiang-Gu Xiang-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add this check for CREATE FUNCTION?

@chengxiong-ruan
Copy link
Contributor Author

Should we also add this check for CREATE FUNCTION?

oh, that has been added before this pr :

cockroach/pkg/sql/opt_exec_factory.go

Line 1850 in 04c6a1a

if err := checkSchemaChangeEnabled(

@chengxiong-ruan
Copy link
Contributor Author

TFTR! 🙏
bors r+

@craig
Copy link
Contributor

craig bot commented Aug 18, 2022

Build succeeded:

@craig craig bot merged commit 2cdb9e2 into cockroachdb:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiang-Gu Xiang-Gu Xiang-Gu approved these changes

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chengxiong-ruan @cockroach-teamcity @ajwerner @Xiang-Gu