sql: fix deterministic ID generation #86276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/fix-deterministic-id-gen
branch
2 times, most recently
from
d15ed6f to
1f5a7e6
Compare
|
The numbers go down because there were statements that would fail but would have incremented the ID generator sequence because it was non-transactional. |
The code was fooling itself: we often did not re-initialize the eval context and thus we were using the old non-transactional generator. Release justification: Only affects testing code. Release note: None
ajwerner
force-pushed
the
ajwerner/fix-deterministic-id-gen
branch
from
1f5a7e6 to
f323841
Compare
|
@chengxiong-ruan PTAL, I reworked some of the UDF tests to avoid hard-coded IDs as inputs |
chengxiong-ruan
approved these changes
Aug 17, 2022
| LANGUAGE SQL | ||
| AS $$ | ||
| SELECT oid::INT8 - 100000 | ||
| FROM pg_proc |
There was a problem hiding this comment.
This is an excellent idea!!!
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was fooling itself: we often did not re-initialize the eval context
and thus we were using the old non-transactional generator.
Release justification: Only affects testing code.
Release note: None