ui/cluster-ui: add context to inform ui if on cockroach cloud #86264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
Great, that's very helpful flag!
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
xinhaoz
force-pushed
the
add-iscloud-flag
branch
from
af559cf to
01d0781
Compare
xinhaoz
changed the title
Closes cockroachdb#86245 This commit introduces a context `CockroachCloudCountext` that signifies whether or not the app is within cockroach cloud or not. This allows us to enable/disable certain features depending on the platform without plumbing any values. The default context value is true in order to not set the context explicitly for cloud components and within the managed-service repo. The context is provided as false for the db-console app. This commit also disables the `Time Spent Waiting` column in active execution tables for CC, since that feature is not yet available. Release justification: bug fix, low risk update to existing functionality Release note (ui change): The `time spent waiting` columns for active execution tables has been hidden on CC
xinhaoz
force-pushed
the
add-iscloud-flag
branch
from
01d0781 to
67043e5
Compare
|
TFTR! |
|
Build succeeded: |
|
@xinhaoz can you backport to 22.1 just the part about adding the context? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86245
This commit introduces a context
CockroachCloudCountextthatsignifies whether or not the app is within cockroach cloud or
not. This allows us to enable/disable certain features depending
on the platform without plumbing any values. The default context
value is true in order to not set the context explicitly for
cloud components and within the managed-service repo. The
context is provided as false for the db-console app.
This commit also disables the
Time Spent Waitingcolumnin active execution tables for CC, since that feature is not yet
available.
Release justification: bug fix, low risk update to existing
functionality
Release note (ui change): The
time spent waitingcolumns foractive execution tables has been hidden on CC