ui: preserve time window selection on window reload #86157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maryliag
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
thank you for looking into it!
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @koorosh)
koorosh
force-pushed
the
ui-preserve-time-window-selection-on-page-reload
branch
from
c917d5d to
879b537
Compare
This patch fixes recently introduced regression when selected time window on SQL Activity or Metrics pages was not preserved after window reload. Now, everytime timescale is changed, it's preserved in session storage and restored on initialization of TimeScale reducer. Release note: None Release justification: low risk, high benefit changes to existing functionality
koorosh
force-pushed
the
ui-preserve-time-window-selection-on-page-reload
branch
from
879b537 to
62a6b1e
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes recently introduced regression when
selected time window on SQL Activity or Metrics pages
was not preserved after window reload.
Now, every time timescale is changed, it's preserved
in session storage and restored on initialization of
TimeScale reducer.
Release note: None
Release justification: low risk, high benefit changes to existing functionality
Resolves: #85815