-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clusterversion,kvserver,sql: remove AutoStatsTableSettings #85939
clusterversion,kvserver,sql: remove AutoStatsTableSettings #85939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @celiala)
b752c83
to
a2a26ea
Compare
TFTR! FYI @msirek that I'm removing Removing
|
a2a26ea
to
321e34e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be OK. This change will only be in 22.2. My understanding is, upgrades are only allowed one minor release at a time, so any nodes running an old version of CRDB would be on 22.1 at the oldest, which does support AutoStatsTableSettings
.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @msirek)
71166f8
to
8aebb6b
Compare
|
26da725
to
9c1b564
Compare
Release note: None Release justification: Remove old version gate.
9c1b564
to
6697549
Compare
TFTR! bors r=msirek |
Build failed (retrying...): |
Build succeeded: |
This commit removes the 22.1
AutoStatsTableSettings
version gate.Cleanup was done following guidance from 21.2 cleanup:
Partially addresses #80663
Release note: None
Release justification: remove old version gates.