sql: add role_id, member_id columns to system.role_members #85928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RichardJCai
force-pushed
the
role_members_table_migration
branch
3 times, most recently
from
30b3ab5 to
ac98b30
Compare
RichardJCai
changed the title
RichardJCai
requested review from
rhu713,
tbg and
ajwerner
and removed request for
a team
Release note: None Release justification: Adding is to system.role_members in same way as system.users, last users table migration for this version. We don't use the IDs to delete or lookup users yet.
RichardJCai
force-pushed
the
role_members_table_migration
branch
from
ac98b30 to
df2efec
Compare
ajwerner
reviewed
Aug 23, 2022
There was a problem hiding this comment.
Given nothing uses this, do we get benefit from having migrated all the tables? Is it correct that nothing uses it?
Reviewed 6 of 24 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @rhu713)
Yeah we don't use it for reads right now. |
5 tasks
|
Superseded by #91517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: add role_id, member_id columns to system.role_members
Release note: None
Release justification: Adding is to system.role_members in same way
as system.users, last users table migration for this version.
We don't use the IDs to delete or lookup users yet.
Last system.users related table migration for 22.2