Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: sql: fix explain gist output to show number of scan span constraints #85348

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 29, 2022

Backport 1/1 commits from #85325 on behalf of @cucaroach.

/cc @cockroachdb/release


If there were span constraints we would always print 1, need to actually
append them to get the count right.

Fixes: #85324

Release note: None


Release justification:

If there were span constraints we would always print 1, need to actually
append them to get the count right.

Fixes: #85324

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 29, 2022 21:05
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-85325 branch from 275a398 to f1a608e Compare July 29, 2022 21:05
@blathers-crl blathers-crl bot requested review from mgartner and rytaft July 29, 2022 21:05
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 29, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 29, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

@cucaroach
Copy link
Contributor

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 1, 2022

👎 Rejected by PR status

@cucaroach
Copy link
Contributor

bors r+

@cucaroach cucaroach merged commit c7b5331 into release-22.1 Aug 2, 2022
@cucaroach cucaroach deleted the blathers/backport-release-22.1-85325 branch August 2, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants