builtins: recategorize some builtins for docs #85346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
force-pushed
the
recategorize-builtins
branch
2 times, most recently
from
4518bc1 to
e211089
Compare
rafiss
requested changes
Aug 1, 2022
jordanlewis
force-pushed
the
recategorize-builtins
branch
from
e211089 to
528a23c
Compare
|
TFTRs - responded to the comments. PTAL |
rafiss
approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis and @rafiss)
pkg/sql/sem/builtins/builtins.go line 3738 at r2 (raw file):
// Fuzzy String Matching "soundex": makeBuiltin( tree.FunctionProperties{Category: builtinconstants.CategoryFuzzyStringMatching},
strange, this didn't show in the generated docs
jordanlewis
force-pushed
the
recategorize-builtins
branch
from
528a23c to
df63186
Compare
This commit moves the json generator functions into the JSON documentation category rather than the more generically named "set-returning functions" category. Also, move the "levenshtein" function into the fuzzy text search category. Also, move another couple of internal functions into "system info". Release note: None
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates cockroachdb/docs#11842
This commit moves the json generator functions into the JSON
documentation category rather than the more generically named
"set-returning functions" category.
Also, move the "levenshtein" function into the fuzzy text search
category.
Also, move another couple of internal functions into "system info".
Release note: None