build: fix dev ui watch #85085
Merged
build: fix dev ui watch #85085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit [1] added a few extra cp commands to an internal helper of the ./dev ui subcommands, but its use in dev ui watch resulted in an attempt to package output before it was created. Revert the unnecessary parts of dc5fb3e, restoring dev ui watch. [1] dc5fb3e (dev: add ./dev generate js subcommand, 2022-07-20) Release note: None
|
This change is |
michae2
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
|
bors r=michae2 |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit [1] added a few extra cp commands to an internal
helper of the ./dev ui subcommands, but its use in dev ui watch resulted
in an attempt to package output before it was created. Revert
the unnecessary parts of dc5fb3e, restoring dev ui watch.
[1] dc5fb3e (dev: add ./dev generate js subcommand, 2022-07-20)
Release note: None