Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logcrash: fix test on arm #84862

Merged
merged 1 commit into from
Jul 21, 2022
Merged

logcrash: fix test on arm #84862

merged 1 commit into from
Jul 21, 2022

Conversation

dt
Copy link
Member

@dt dt commented Jul 21, 2022

Release note: none.

@dt
logcrash: fix test on arm
617c32a 
Release note: none.
@dt dt requested review from knz and a team July 21, 2022 17:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt requested a review from rickystewart July 21, 2022 17:54
rickystewart
rickystewart approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the test failure on my machine, looks good.

@dt
Copy link
Member Author

dt commented Jul 21, 2022

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 21, 2022

Build succeeded:

@craig craig bot merged commit 79edfce into cockroachdb:master Jul 21, 2022
@dt dt deleted the logcrash branch August 4, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

@knz knz Awaiting requested review from knz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dt @cockroach-teamcity @rickystewart