-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.1: sql: add statement fingerprint ID to sampled query #84857
Conversation
Remove unused `Fingerprint()` function from `roachpb`. Release note: None
This change adds the statement fingerprint ID to the sampled query log, allowing us to measure the uniqueness of a workload. Release note (sql change): Sampled query telemetry log now includes the statement's fingerprint ID.
1cf6080
to
75b1506
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @abarganier, @THardy98, and @xinhaoz)
Backport 2/2 commits from #84182 on behalf of @THardy98.
/cc @cockroachdb/release
Partially addresses: #71328
This change adds the statement fingerprint ID to the sampled query log,
allowing us to measure the uniqueness of a workload.
Release note (sql change): Sampled query telemetry log now includes the
statement's fingerprint ID.
Release justification: Category 4: Low risk, high benefit changes to existing functionality