sql: ensure revalidate_unique_constraint* builtins respect privileges

[rytaft]

This commit updates the builtins
crdb_internal.revalidate_unique_constraints_in_all_tables,
crdb_internal.revalidate_unique_constraints_in_table,
and crdb_internal.revalidate_unique_constraint to ensure that the correct
user is passed to the internal executor when running the validation query.
This ensures that privileges will be respected.

Release note (bug fix): Fixed the following builtins so that users can only
run them if they have SELECT privileges on the relevant tables:
crdb_internal.revalidate_unique_constraints_in_all_tables,
crdb_internal.revalidate_unique_constraints_in_table,
and crdb_internal.revalidate_unique_constraint.

[cockroach-teamcity]

This change is 

[knz]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @msbutler, @rafiss, and @rytaft)

---

pkg/sql/backfill.go line 2608 at r1 (raw file):

			ie,
			txn,
			username.NodeUserName(),

why node here?

---

pkg/sql/importer/import_job.go line 1124 at r1 (raw file):

			ie := execCfg.InternalExecutorFactory(ctx, sql.NewFakeSessionData(execCfg.SV()))
			return ie.WithSyntheticDescriptors([]catalog.Descriptor{desc}, func() error {
				return sql.RevalidateUniqueConstraintsInTable(ctx, txn, username.NodeUserName(), ie, desc)

I think this should use the job user owner instead of node.

[rytaft]

TFTRs!

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz, @msbutler, and @rafiss)

---

pkg/sql/backfill.go line 2608 at r1 (raw file):

Previously, knz (kena) wrote…

why node here?

Fixed.

---

pkg/sql/importer/import_job.go line 1124 at r1 (raw file):

Previously, knz (kena) wrote…

I think this should use the job user owner instead of node.

Done.

[msbutler]

Looks good on the bulk side!

[knz]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @rytaft)

---

pkg/sql/backfill.go line 768 at r2 (raw file):

				} else if c.IsUniqueWithoutIndex() {
					if err := validateUniqueWithoutIndexConstraintInTxn(
						ctx, sc.ieFactory(ctx, evalCtx.SessionData()), desc, txn, username.NodeUserName(), c.GetName(),

maybe evalCtx.SessionData().User() here?

[rytaft]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz and @rafiss)

---

pkg/sql/backfill.go line 768 at r2 (raw file):

Previously, knz (kena) wrote…

maybe evalCtx.SessionData().User() here?

Done.

[mgartner]

Reviewed 1 of 4 files at r1, 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz and @rafiss)

[knz]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

[rytaft]

TFTRs!

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

[craig]

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

[craig]

GitHub status checks took too long to complete, so bors is giving up. You can adjust bors configuration to have it wait longer if you like.

[rytaft]

bors r+

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

[craig]

Build failed (retrying...):

• GitHub CI (Cockroach)

[craig]

Build succeeded:

• GitHub CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from d2715d2 to blathers/backport-release-21.2-83959: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.

---

error creating merge commit from d2715d2 to blathers/backport-release-22.1-83959: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.}