sql: add identifiers to sampled query #83938
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #71328
This change introduces identifiers into the sampled query log, namely:
Adding transaction ID incurs an additional lock access, the difference in performance is negligible. Results after running
kv95
on a 3 node GCE cluster using roachprod:Release note (sql change): Sampled query telemetry log now includes
session/transaction/statement IDs, and database name of the query.