Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: fix target path when getting cluster artifacts. #83923

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

renatolabs
Copy link
Contributor

A bug was introduced in the computation of the local path where
cluster artifacts are downloaded: instead of prefixing the path with
the node ID, the list of nodes would be used instead. This results
in (other than weird looking paths, such as [1 2 3 4].logs) only the
logs for the last node being downloaded.

This commit fixes the issue by using the node ID correctly.

Release note: None.

A bug was introduced in the computation of the local path where
cluster artifacts are downloaded: instead of prefixing the path with
the node ID, the list of nodes would be used instead. This results
in (other than weird looking paths, such as `[1 2 3 4].logs`) only the
logs for the last node being downloaded.

This commit fixes the issue by using the node ID correctly.

Release note: None.
@renatolabs renatolabs added A-testing Testing tools and infrastructure T-testeng TestEng Team labels Jul 6, 2022
@renatolabs renatolabs requested a review from a team as a code owner July 6, 2022 18:40
@renatolabs renatolabs requested review from stevendanna and removed request for a team July 6, 2022 18:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@renatolabs renatolabs requested a review from a team July 6, 2022 18:41
@renatolabs
Copy link
Contributor Author

Using Tobi's reproduction steps on this branch:

$ ./bin/roachprod create -n 3 local
18:30:45 roachprod.go:1266: Creating cluster local with 3 nodes
$ ./bin/roachprod ssh local -- mkdir -p logs
local: mkdir -p logs 3/3
   1: 
   2: 
   3: 
$ ./bin/roachprod get local logs
18:31:09 cluster_synced.go:1839: local: getting logs logs on nodes [1 2 3]
   1: done
   2: done
   3: done
$ ls | grep logs
1.logs
2.logs
3.logs

@renatolabs
Copy link
Contributor Author

bors r=srosenberg

@craig
Copy link
Contributor

craig bot commented Jul 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 7, 2022

Build succeeded:

@craig craig bot merged commit 1abab4c into cockroachdb:master Jul 7, 2022
@renatolabs renatolabs deleted the fix-roachprod-get-path branch July 7, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure T-testeng TestEng Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants