sql/schemachanger: extend metadata updater to support for updating zone configs #83804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
metaDataUpdateZC
branch
3 times, most recently
from
3b2f5b6 to
3dd75b3
Compare
ajwerner
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, 17 of 17 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dt and @fqazi)
pkg/sql/descmetadata/metadata_updater.go line 46 at r1 (raw file):
descriptors *descs.Collection cacheEnabled bool codec keys.SQLCodec
Is this used anymore?
Previously, there was no way for the declarative schema changer to set zone configs without invoking into sql, which would lead to a circular dependency. These changes add an interface for allow the declarative schema changes to issue zone config updates via the MetadataUpdater. Release note: None
fqazi
commented
Jul 7, 2022
There was a problem hiding this comment.
@ajwerner TFTR!
Reviewable status:
pkg/sql/descmetadata/metadata_updater.go line 46 at r1 (raw file):
Previously, ajwerner wrote…
Is this used anymore?
Done.
Previously, the code to update the zone configs was separate between the declarative schema changer and the legacy schema changer. This was inadequate because we have a opportunity to share logic here. To address this the logic to update and delete zone configurations is now shared. Release note: None
|
bors r+ |
|
Build succeeded: |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will extend the metadata updater to first support updating zone config, and next adopt
this infrastructure inside the existing zone config code.