Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwire: allow Flush message during portal exeuction #83675

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jun 30, 2022

fixes #83613

Release note (bug fix): A Flush message sent during portal execution in
the pgwire extended protocol no longer results in an error.

@rafiss rafiss requested review from RichardJCai and a team June 30, 2022 19:33
@rafiss rafiss requested a review from a team as a code owner June 30, 2022 19:33
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss requested a review from jordanlewis June 30, 2022 19:33
Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but for minor comments!

pkg/sql/pgwire/testdata/pgtest/portals Show resolved Hide resolved
pkg/sql/pgwire/command_result.go Outdated Show resolved Hide resolved
Release note (bug fix): A Flush message sent during portal execution in
the pgwire extended protocol no longer results in an error.
@rafiss rafiss force-pushed the flush-during-portal branch from 3e3b41c to 249e6fd Compare July 6, 2022 15:12
@rafiss
Copy link
Collaborator Author

rafiss commented Jul 6, 2022

tftr!

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Jul 6, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 6, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jul 7, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgwire: Flush message is not supported during execution of a portal
3 participants