backupccl: deflake TestMetadataSST #83561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix for failures in TestMetadataSST.
First,
backup_metadata_test.go:49: error executing 'BACKUP TO $1': pq: a
CCL binary is required to use this statement type: *tree.Backup
is solved by moving the test back into the backupccl package so that
the plan hook for BACKUP is definitely registered.
Second,
backup_metadata_test.go:89: file /0/BACKUP_MANIFEST does not exist
in the UserFileTableSystem: external_storage: file doesn't exist
is solved by disabling tenants by default in the setup functions in
backuputils. There is duplication between these functions and the
functions in backupccl, where we already disable tenants. The error
above is likely the result of us directly using the internal executor
of the server to query the userfile storage, which may be incorrect if
we were actually talking to a tenant.
Release note: None
|
This change is |
adityamaru
approved these changes
Jun 29, 2022
|
bors r+ |
|
Build failed (retrying...): |
|
bors retry |
|
Already running a review |
|
bors r+ p=9999 single on |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for failures in TestMetadataSST.
First,
is solved by moving the test back into the backupccl package so that
the plan hook for BACKUP is definitely registered.
Second,
is solved by disabling tenants by default in the setup functions in
backuputils. There is duplication between these functions and the
functions in backupccl, where we already disable tenants. The error
above is likely the result of us directly using the internal executor
of the server to query the userfile storage, which may be incorrect if
we were actually talking to a tenant.
Release note: None