sql: harden the check for when leaf txn can used #83299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rharding6373
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @michae2)
This commit refactors the code where we determine whether we have to make a leaf txn for the local flow (which is the case when we either parallelize scans or use the streamer API) to be "stronger". We recently saw a nil-pointer error when trying to create a streamer (the txn was nil), and the only case I could see this happening was that if `makeLeaf` function returned nil which can occur if the original txn was nil. I still don't see how that could happen (and neither could I reproduce it), but this commit makes the code more bullet-proof so that we ensure that `LeafTxnInputState` is non-nil when we expect to have concurrency. Release note: None
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the code where we determine whether we have to
make a leaf txn for the local flow (which is the case when we either
parallelize scans or use the streamer API) to be "stronger". We recently
saw a nil-pointer error when trying to create a streamer (the txn was
nil), and the only case I could see this happening was that if
makeLeaffunction returned nil which can occur if the original txn wasnil. I still don't see how that could happen (and neither could
I reproduce it), but this commit makes the code more bullet-proof so
that we ensure that
LeafTxnInputStateis non-nil when we expect tohave concurrency.
Fixes: #83259.
Release note: None