util/stop: fix span use when recovering from a panic #83290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recovering from a panic, the stopper was first finishing the tracing span and then using it to log the panic. This was a use-after-finish. It was not caught by the unit test because the test was short-circuiting the logging part; I've improved the test so that it would have caught it. Release note: None
The goroutine dealing with reading from a pgwire connection was logging panics, but that was redundant with what the Stopper was about to also do. Release note: None
|
This change is |
knz
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
andreimatei
commented
Jun 23, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recovering from a panic, the stopper was first finishing the
tracing span and then using it to log the panic. This was a
use-after-finish. It was not caught by the unit test because the test
was short-circuiting the logging part; I've improved the test so that it
would have caught it.
Release note: None