Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: clarify exception to conditional evaluation guarantee #83196

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

mgartner
Copy link
Collaborator

See #20298 and #82498 for additional context.

Release note: None

@mgartner mgartner requested a review from msirek June 22, 2022 16:50
@mgartner mgartner requested a review from a team as a code owner June 22, 2022 16:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner force-pushed the clarify-volatility-guarantees branch from 3397927 to 58cb9e5 Compare June 22, 2022 16:50
@mgartner mgartner requested a review from michae2 June 22, 2022 16:50
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msirek)

@mgartner mgartner force-pushed the clarify-volatility-guarantees branch from 58cb9e5 to d5b490b Compare June 22, 2022 19:55
@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 23, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 23, 2022

Build succeeded:

@craig craig bot merged commit 826680e into cockroachdb:master Jun 23, 2022
@mgartner mgartner deleted the clarify-volatility-guarantees branch June 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants