-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/cluster-ui: fix transaction details stmts table pagination #83191
Conversation
This is a different issue than what was seen in #81470, but just something I discovered during that investigation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
ed7bbcd
to
f3a1013
Compare
Previously, the pagination used by the stmts table in the transaction details page used the length associated with the unaggregated list of statements retrieved for a transaction. This lead to the table reporting more stmts for a transaction than available. Release note (bug fix): The statements table for a txn in the txn details page now shows the correct number of stmts for a transaction.
f3a1013
to
d6ad0a3
Compare
bors r=maryliag |
Already running a review |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d6ad0a3 to blathers/backport-release-22.1-83191: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, the pagination used by the stmts table in the
transaction details page used the length associated with
the unaggregated list of statements retrieved for a
transaction. This lead to the table reporting more
stmts for a transaction than available.
Release note (bug fix): The statements table for a txn
in the txn details page now shows the correct number of
stmts for a transaction.
Before: There are clearly 5 statements in the txn text and stmts table, but the stmts table pagination shows 9.
After: correct number of stmts reported