Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/cluster-ui: fix transaction details stmts table pagination #83191

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Jun 22, 2022

Previously, the pagination used by the stmts table in the
transaction details page used the length associated with
the unaggregated list of statements retrieved for a
transaction. This lead to the table reporting more
stmts for a transaction than available.

Release note (bug fix): The statements table for a txn
in the txn details page now shows the correct number of
stmts for a transaction.

Before: There are clearly 5 statements in the txn text and stmts table, but the stmts table pagination shows 9.
image

After: correct number of stmts reported
image

@xinhaoz xinhaoz requested a review from a team June 22, 2022 15:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz
Copy link
Member Author

xinhaoz commented Jun 22, 2022

This is a different issue than what was seen in #81470, but just something I discovered during that investigation.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@xinhaoz xinhaoz force-pushed the txn-details-bugs branch 2 times, most recently from ed7bbcd to f3a1013 Compare June 23, 2022 17:47
Previously, the pagination used by the stmts table in the
transaction details page used the length associated with
the unaggregated list of statements retrieved for a
transaction. This lead to the table reporting more
stmts for a transaction than available.

Release note (bug fix): The statements table for a txn
in the txn details page now shows the correct number of
stmts for a transaction.
@xinhaoz xinhaoz force-pushed the txn-details-bugs branch from f3a1013 to d6ad0a3 Compare June 23, 2022 20:06
@xinhaoz
Copy link
Member Author

xinhaoz commented Jun 24, 2022

bors r=maryliag

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Already running a review

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Build succeeded:

@craig craig bot merged commit 12462e8 into cockroachdb:master Jun 24, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 24, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d6ad0a3 to blathers/backport-release-22.1-83191: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants