Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: run build/bazelutil/check.sh after dev generate #83188

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

rickystewart
Copy link
Collaborator

This runs a couple additional checks. I add a fast path to the script to
make sure this doesn't stall anyone.

Release note: None

@rickystewart rickystewart requested a review from rail June 22, 2022 15:19
@rickystewart rickystewart requested a review from a team as a code owner June 22, 2022 15:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)

@rickystewart
Copy link
Collaborator Author

bors r=rail

@rickystewart
Copy link
Collaborator Author

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Canceled.

This runs a couple additional checks. I add a fast path to the script to
make sure this doesn't stall anyone.

Release note: None
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Build failed:

@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 24, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants