cli/sql: support for client-side \o
#83118
Conversation
|
This change is |
There was a problem hiding this comment.
nice. just had some testing comments
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @knz and @otan)
pkg/cli/interactive_tests/test_local_cmds.tcl line 272 at r1 (raw file):
send "\\o logs/query-output.txt\r" eexpect root@ send "select 'hello world';\r"
does the output appear in the CLI as well (like tee)? if so, add a test for that
also, perhaps add a test to see how query syntax/execution errors are redirected to that file
pkg/cli/interactive_tests/test_local_cmds.tcl line 283 at r1 (raw file):
eexpect "hello" eexpect root@ end_test
nit: test qecho as well
There was a problem hiding this comment.
Reviewable status:
pkg/cli/interactive_tests/test_local_cmds.tcl line 272 at r1 (raw file):
does the output appear in the CLI as well (like tee)?
nope
also, perhaps add a test to see how query syntax/execution errors are redirected to that file
they're not (like in psql), but good point to test. Done.
pkg/cli/interactive_tests/test_local_cmds.tcl line 283 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
nit: test
qechoas well
Good point. Done.
Release note (cli change): `cockroach sql` (and thus `cockroach demo` too) now support the client-side commands `\o` and `\qecho` like `psql`. The command `\o` can redirect the output of SQL queries to a file. `\qecho` adds an arbitrary text to the current query output file.
|
RFAL |
There was a problem hiding this comment.
looks great!
Reviewed 6 of 7 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:
|
thanks! bors r=rafiss |
|
Build failed: |
|
unrelated flake bors r=rafiss |
|
Build succeeded: |
Release note (cli change):
cockroach sql(and thuscockroach demotoo) now support the client-side commands
\oand\qecholikepsql. The command\ocan redirect the output of SQL queries to afile.
\qechoadds an arbitrary text to the current query output file.