cmd/reduce: reduce costfuzz logs #83021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
michae2
force-pushed
the
reduce_costfuzz
branch
2 times, most recently
from
f0b6ac8 to
6bdaa1f
Compare
Add a `-costfuzz` mode to `reduce`, with special handling for logs produced by the costfuzz roachtest. This mode is similar to `-tlp`. The logs produced by costfuzz consist of various CREATE TABLE, INSERT, UPDATE, and DELETE statements followed by three special statements: 1. A SELECT statement, called "control". 2. A SET testing_optimizer_random_cost_seed statement. 3. The same SELECT as (1), this time called "perturbed". When the results of (1) and (3) do not match, we have a costfuzz failure. The `-costfuzz` mode removes these three special statements from the end of the log, reduces the rest of the log, and then appends the statements to the reduced log to check if the current reduction is interesting. As long as the results of (1) and (3) continue to not match, the reduction is interesting. Also, make `reduce` run `cockroach demo` with an enterprise license. Now that we use enterprise features in randgen we sometimes need this. Informs: cockroachdb#81717 Release note: None
msirek
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
This is great!
Reviewable status:
complete! 1 of 0 LGTMs obtained
|
TFYR! bors r=msirek |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
-costfuzzmode toreduce, with special handling for logsproduced by the costfuzz roachtest. This mode is similar to
-tlp.The logs produced by costfuzz consist of various CREATE TABLE, INSERT,
UPDATE, and DELETE statements followed by three special statements:
When the results of (1) and (3) do not match, we have a costfuzz
failure.
The
-costfuzzmode removes these three special statements from the endof the log, reduces the rest of the log, and then appends the statements
to the reduced log to check if the current reduction is interesting. As
long as the results of (1) and (3) continue to not match, the reduction
is interesting.
Also, make
reduceruncockroach demowith an enterprise license. Nowthat we use enterprise features in randgen we sometimes need this.
Informs: #81717
Release note: None