Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: changefeedccl: Do not inhibit node shutdown #82876

Merged
merged 2 commits into from
Jul 5, 2022
Merged

release-21.2: changefeedccl: Do not inhibit node shutdown #82876

merged 2 commits into from
Jul 5, 2022

Conversation

miretskiy
Copy link
Contributor

@miretskiy miretskiy commented Jun 14, 2022 •
edited
Loading

Backport 2/2 commits from #82768.

/cc @cockroachdb/release

See individual commits for details:

Test not being merged as part of this PR -- see #82767

Release Notes (bug fix): Ensure running changefeeds do
not inhibit node shutdown.
Release Notes (bug fix): Treat node unavailable error as a retryable changefeed error.

Release Justification: Bug fix

@miretskiy miretskiy requested a review from a team as a code owner June 14, 2022 11:54
@miretskiy miretskiy requested review from gh-casper and removed request for a team June 14, 2022 11:54
@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy requested a review from HonoreDB June 14, 2022 17:02
Yevgeniy Miretskiy added 2 commits July 5, 2022 11:42
changefeedccl: Handle node unavailable error.
6ebd243 
Treat NodeUnavailable error as a retryable changefeed error.

NodeUnavaiable error may be returned by changefeed processors if the
node is being shutdown/drained.  However, this error return is racy.
Sometimes, the coordinator would see "rpc context cancellation" error
instead -- in those cases it would treat the error as retryable.
However, sometimes it is possible to get this error propagated
(for example: when server shutdown races with starting up kv feed,
which uses Stopper, whcih may return NodeUnavailable error if it's
being shutdown).

Release Notes (bug fix): Treat node unavailable error as a retryable
changefeed error.
changefeedccl: Do not inhibit server shutdown.
3f3eb92 
Informs cockroachdb#82765

Permanet fix is being tracked by the above issue.
This is a temporary fix to ensure that change aggregators
cancel their context when the server quiesces so that the
server shutdown is not inhibited by the running changefeeds.

The test for this functionality is not being merged due
to the fact that it takes too long to run; however, the test
can be seen here: cockroachdb#82767

Release Notes (bug fix): Ensure running changefeeds do
not inhibit node shutdown.
@miretskiy miretskiy force-pushed the backport21.2-82768 branch from fa34c6c to 3f3eb92 Compare July 5, 2022 15:47
@miretskiy miretskiy merged commit 921e7e4 into cockroachdb:release-21.2 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonoreDB HonoreDB HonoreDB approved these changes

@gh-casper gh-casper Awaiting requested review from gh-casper gh-casper is a code owner automatically assigned from cockroachdb/cdc-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miretskiy @cockroach-teamcity @HonoreDB