kvstreamer: extend a test to assert that the streamer is used #82671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rharding6373
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Great, thank you!
Reviewed all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
|
TFTR! bors r+ |
|
Looks like the test might be flaky. bors r- |
|
Canceled. |
yuzefovich
force-pushed
the
streamer-tests
branch
from
5a6eca0 to
d868bf9
Compare
|
The adjusted test started being flaky in rare circumstances due to join reader not behaving under memory pressure for the lookup join with ordering test case. Opened up #82693 to fix that and will merge this PR once that PR goes in. |
This commit extends an existing test which examines the trace of different queries to assert that the streamer is used in all cases when we expect. It also simplifies some of the queries as well as adjusts the workmem limit which got out of sync with the index join memory limiting behavior which was changed recently. Release note: None
yuzefovich
force-pushed
the
streamer-tests
branch
from
d868bf9 to
817fac5
Compare
|
Should be good now. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends an existing test which examines the trace of
different queries to assert that the streamer is used in all cases when
we expect. It also simplifies some of the queries as well as adjusts the
workmem limit which got out of sync with the index join memory limiting
behavior which was changed recently.
Fixes: #82646.
Release note: None