randgen: fix postgres mutator for session vars #82548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
reviewed
Jun 7, 2022
pkg/sql/randgen/mutator.go
Outdated
| @@ -832,6 +833,8 @@ func postgresCreateTableMutator( | |||
| } | |||
| } | |||
| stmt.Defs = newdefs | |||
| case *tree.SetVar: | |||
|
|
|||
There was a problem hiding this comment.
hmm, does this mean we lose out on stuff like SET intervalstyle = '...', and do we (deliberately) want to do that?
Release note: None
Release note: None
We support enough of these extensions that we should start allowing these statements, similar to how we did for pg_trgm. Release note: None
rafiss
force-pushed
the
fix-postgres-mutator
branch
from
ab9529f to
154f5e1
Compare
otan
approved these changes
Jun 13, 2022
|
bors r=otan |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67791
Release note: None