kv: add debug information to track down #77663 #82151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/debug77663
branch
from
c38e7b2 to
4ee56ed
Compare
knz
reviewed
Jun 1, 2022
| log.Event(ctx, "optimistically sequencing request") | ||
| case PessimisticAfterFailedOptimisticEval: | ||
| branch = 3 |
There was a problem hiding this comment.
these branches will not fire given the panic underneath, right?
maybe you want a defer that wraps the branch number around the panic object?
There was a problem hiding this comment.
No, they won't fire, so this is intentionally dead code. I removed it.
irfansharif
approved these changes
Jun 20, 2022
I've given cockroachdb#77663 a few looks and have yet to understand how it is possible to hit that assertion. To continue making progress, this commit adds additional debug information to the assertion so that we'll be able to understand this better if it happens again.
nvanbenschoten
force-pushed
the
nvanbenschoten/debug77663
branch
from
4ee56ed to
8e6b85b
Compare
|
TFTR! bors r=irfansharif |
|
Build failed (retrying...): |
|
Build succeeded: |
This was referenced Jul 6, 2022
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've given #77663 a few looks and have yet to understand how it is
possible to hit that assertion. To continue making progress, this commit
adds additional debug information to the assertion so that we'll be able
to understand this better if it happens again.