Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add logictest config thats disables locality optimized search #81981

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

rharding6373
Copy link
Collaborator

@rharding6373 rharding6373 commented May 27, 2022

This PR increases test coverage by disabling locality optimized search
for some tests. Locality optimized search is enabled by default.

Fixes: #73633

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This PR increases test coverage by disabling locality optimized search
for some tests. Locality optimized search is enabled by default.

Fixes: cockroachdb#73633

Release note: None
@rharding6373 rharding6373 requested review from rytaft and msirek May 27, 2022 17:33
@rharding6373 rharding6373 marked this pull request as ready for review May 27, 2022 19:42
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msirek)

Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @rharding6373)

@rharding6373
Copy link
Collaborator Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 2, 2022

Build succeeded:

@craig craig bot merged commit daf3b48 into cockroachdb:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl: run CCL logictests in a mode with locality optimized search disabled
4 participants