-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppc64le - fix test failure of TestSegmentize/GEOMETRYCOLLECTION_ #81894
ppc64le - fix test failure of TestSegmentize/GEOMETRYCOLLECTION_ #81894
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
@otan, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! lgtm, but needs a small commit message update
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @prashantkhoje and @rafiss)
-- commits
line 2 at r1:
please add Release note: None
to the commit message body
Release note: None
7901d78
to
1d53ba7
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
bors r+
Build succeeded: |
Allow floating point approximation within an epsilon