Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le - fix test failure of TestSegmentize/GEOMETRYCOLLECTION_ #81894

Merged

Conversation

prashantkhoje
Copy link
Contributor

Allow floating point approximation within an epsilon

@blathers-crl
Copy link

blathers-crl bot commented May 26, 2022

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels May 26, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@prashantkhoje
Copy link
Contributor Author

@otan, please review.

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm, but needs a small commit message update

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @prashantkhoje and @rafiss)


-- commits line 2 at r1:
please add Release note: None to the commit message body

@rafiss rafiss requested a review from otan May 26, 2022 18:27
@prashantkhoje prashantkhoje force-pushed the ppc64le-geomfn-TestSegmentize branch from 7901d78 to 1d53ba7 Compare May 27, 2022 06:18
@blathers-crl
Copy link

blathers-crl bot commented May 27, 2022

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@prashantkhoje prashantkhoje requested a review from rafiss May 27, 2022 07:50
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

bors r+

@craig
Copy link
Contributor

craig bot commented May 27, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants