-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.1: acceptance: run python
, psql
containers as current uid
#81665
release-21.1: acceptance: run python
, psql
containers as current uid
#81665
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
(there is a test failing tho) |
19785b7
to
16a6c77
Compare
@knz Cherry-picking the fix to
I then tried to update
I don't know what the exact root cause of this is but I don't know if Can you advise about what changes we need to make to get the test working on |
The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR cockroachdb#71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None
Need to rebase on top of #81730. |
I see I can't merge #81730 without this PR, and this one can't merge without the other one. So I think the best way is to integrate the two commits into one PR (presumably this one). |
Manual cherry-pick from cockroachdb#81460. `postgres`'s permission checking for certificates has gotten more rigorous since [this commit](https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a59c79564bdc209a5bc7b02d706f0d7352eb82fa). This has broken a couple `acceptance` tests which do not pin to any specific `postgres` version (see cockroachdb#81313, cockroachdb#81437). Here we attempt to solve the problem "once and for all" by ensuring that these containers run with a UID that is equal to the one that created the certificates. Release note: None
16a6c77
to
b065031
Compare
Done, going to make sure it passes CI. |
Manual cherry-pick from #81460.
postgres
's permission checking for certificates has gotten morerigorous since this commit.
This has broken a couple
acceptance
tests which do not pin to anyspecific
postgres
version (see #81313, #81437).Here we attempt to solve the problem "once and for all" by ensuring that
these containers run with a UID that is equal to the one that created
the certificates.
Release note: None
Release justification: Test-only change