Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: acceptance: update how we build the python compose image #81395

Merged

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented May 17, 2022

Backport from #81313.

Up until this point we were using apt install postgresql-client to
install the psql binary in this image. Because the postgresql-client
apt package was apparently updated to a later version of postgres
last week that includes this change,
the TestComposeGSSPython acceptance test started failing with the
following error:

psql: error: private key file "/certs/client.root.key" must be owned by the current user or root

Less recent versions of psql are more permissive about cert
permissions, so we work around this by manually installing postgres 11.

Release note: None
Release justification: Test-only change

@rickystewart rickystewart requested a review from a team May 17, 2022 18:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart requested a review from rail May 17, 2022 18:36
@rickystewart rickystewart changed the title acceptance: update how we build the python compose image release-21.1: acceptance: update how we build the python compose image May 17, 2022
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

Up until this point we were using `apt install postgresql-client` to
install the `psql` binary in this image. Because the `postgresql-client`
`apt` package was apparently updated to a later version of `postgres`
last week that includes [this change](https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a59c79564bdc209a5bc7b02d706f0d7352eb82fa),
the `TestComposeGSSPython` `acceptance` test started failing with the
following error:

```
psql: error: private key file "/certs/client.root.key" must be owned by the current user or root
```

Less recent versions of `psql` are more permissive about cert
permissions, so we work around this by manually installing postgres 11.

Release note: None
Release justification: Test-only change
@rickystewart rickystewart merged commit d6c2fe5 into cockroachdb:release-21.1 May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants