backupccl,roachpb: introduce Aggregator to listen for StructuredEvents #81270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
force-pushed
the
bulk-aggregator
branch
2 times, most recently
from
9bef780 to
69222ee
Compare
adityamaru
force-pushed
the
bulk-aggregator
branch
from
69222ee to
9544f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an Aggregator that can be registered as an EventListener
and LazyTag on a tracing span. The Aggregator will be notified on every
StructuredEvent emitted in the span's recording, and will subsume the event
into a running aggregate stored in memory.
This running aggregate will be rendered on the span's recording as a LazyTag
that can be consumed via the
tracezpage on the debug console.Currently, the backup processor is the only bulk processor that creates and
registers an Aggregator. As an initial prototype this change teaches every
ExportRequest to emit ExportStats that will be aggregated by the Aggregator.
Note, this change also removes various StructuredEvents that were emitted by
the backup processor but have never proved useful. These were added as part of
the
cockroach debug job-tracecommand which we hope to replace with this Aggregator.Informs: #80388
Release note: None